fix(scanner): enable multi-file cross-taint analysis across all supported languages - #67
Open
Adityakk9031 wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@juangaitanv and @Ibrahimrahhal have a look |
juangaitanv
self-requested a review
August 17, 2026 08:32
juangaitanv
reviewed
Aug 18, 2026
Comment on lines
+334
to
+335
| for file_path in files { | ||
| self.analyze_file_for_imports_exports(file_path, language, &rule_deduplicator)?; |
Contributor
There was a problem hiding this comment.
a read or parser failure aborts all cross-file analysis and produces no findings; could we handle failures per file and continue?
Comment on lines
+1190
to
+1199
| let py_pattern = format!("def {}(", function_name); | ||
| let js_pattern1 = format!("function {}(", function_name); | ||
| let js_pattern2 = format!("const {} =", function_name); | ||
| let js_pattern3 = format!("let {} =", function_name); | ||
| let fn_pattern = format!("fn {}(", function_name); | ||
| content.contains(&py_pattern) | ||
| || content.contains(&js_pattern1) | ||
| || content.contains(&js_pattern2) | ||
| || content.contains(&js_pattern3) | ||
| || content.contains(&fn_pattern) |
Contributor
There was a problem hiding this comment.
const and let bindings are treated as functions while body extraction accepts only Python def; could we limit lookup to callable declarations and align body extraction?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary