fix(prefilter): use token-boundary matching for test and migration framework detection - #68
Open
Adityakk9031 wants to merge 1 commit into
Conversation
…amework detection
juangaitanv
self-requested a review
August 17, 2026 08:32
juangaitanv
reviewed
Aug 18, 2026
| ]; | ||
|
|
||
| test_patterns.iter().any(|pattern| imports_text.contains(pattern)) | ||
| test_patterns.iter().any(|pattern| Self::matches_token_or_module(imports_text, pattern)) |
Contributor
There was a problem hiding this comment.
vitest, Go testing, and testify no longer match the test patterns, so their imports are scanned. could we retain explicit patterns for these framework roots while preserving the boundary fix?
Comment on lines
-249
to
-251
| "migration", | ||
| "migrations", | ||
| "migrate", |
Contributor
There was a problem hiding this comment.
from django.db import migrations no longer matches a migration pattern, so those files are scanned in general mode. could we retain generic migration indicators while treating _ and digits as identifier characters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary