fix(codetype): support multiline and side-effect import detection - #69
Open
Adityakk9031 wants to merge 2 commits into
Open
fix(codetype): support multiline and side-effect import detection#69Adityakk9031 wants to merge 2 commits into
Adityakk9031 wants to merge 2 commits into
Conversation
juangaitanv
self-requested a review
August 17, 2026 08:32
juangaitanv
reviewed
Aug 18, 2026
| regex::Regex::new(r#"import\s+.*from\s+['"]([^'"]+)['"]"#).unwrap(), | ||
| regex::Regex::new(r#"(?s)import\s+.*?from\s+['"]([^'"]+)['"]"#).unwrap(), | ||
| regex::Regex::new(r#"import\s*\(\s*['"]([^'"]+)['"]\s*\)"#).unwrap(), | ||
| regex::Regex::new(r#"import\s+['"]([^'"]+)['"]"#).unwrap(), |
Contributor
There was a problem hiding this comment.
a Go import such as github.com/reactivex/rxgo can match the react signature and override the Backend fallback; should we limit this extraction to applicable languages?
Contributor
Author
There was a problem hiding this comment.
@juangaitanv Thanks! Restricted extract_imports in src/code_type_detector.rs to JavaScript / TypeScript languages (javascript, typescript, tsx, jsx, js, ts), ensuring non-JS languages like Go or Python do not extract false JS framework signatures and cleanly retain their backend classification. Added regression test non_js_imports_do_not_override_backend_default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary