fix(ast_provenance): resolve duplicate function definitions by usage line span - #71
Open
Adityakk9031 wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@juangaitanv and @Ibrahimrahhal have a look |
juangaitanv
self-requested a review
August 17, 2026 08:32
juangaitanv
reviewed
Aug 18, 2026
Comment on lines
+123
to
+141
| let function = match function_list.len() { | ||
| 0 => return None, | ||
| 1 => &function_list[0], | ||
| _ => { | ||
| if let Some(line) = usage_line { | ||
| let matching: Vec<&FunctionFacts> = function_list | ||
| .iter() | ||
| .filter(|f| line >= f.span.0 && line <= f.span.1) | ||
| .collect(); | ||
| if matching.len() == 1 { | ||
| matching[0] | ||
| } else { | ||
| return Some(AstResolution::Ambiguous); | ||
| } | ||
| } else { | ||
| return Some(AstResolution::Ambiguous); | ||
| } | ||
| } | ||
| }; |
Contributor
There was a problem hiding this comment.
when the selected definition has no local facts, the text fallback can resolve a different same-named definition; could we return AstResolution::Ambiguous instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esolve_variable_reaching\ to match the sink's \usage_line\ against each definition's line span when multiple methods in a file share the same bare name (e.g. \get, \post,
un, \handle\ across multiple classes).