Conversation
…with toast - Remove 8 deprecated commands: provider, providers, mcp-tools, mcp-auth, mcp-reload, mcp-logs, crash, eval - Change toast position from TopRight to BottomLeft - Replace AuthAlertModal with toast notifications for authentication - Delete alert.rs module (no longer needed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactoring of the TUI to clean up deprecated commands and improve the alert notification system.
Changes
Commands Removed (8 deprecated)
provider- Not implementedproviders- Not implementedmcp-tools- Not implementedmcp-auth- Not implementedmcp-reload- Not implementedmcp-logs- Not implementedcrash- Debug only, not neededeval- Not implementedAlert System Improvements
AuthAlertModalwith ephemeral toast notificationsalert.rsmodule (no longer needed)Files Changed
src/cortex-tui/src/app/state.rs- Toast position updatesrc/cortex-tui/src/commands/registry/builtin.rs- Removed deprecated commandssrc/cortex-tui/src/modal/alert.rs- Deletedsrc/cortex-tui/src/modal/mod.rs- Removed alert modulesrc/cortex-tui/src/runner/event_loop/modal.rs- Use toast instead of AuthAlertModalsrc/cortex-tui/src/runner/event_loop/streaming.rs- Use toast instead of AuthAlertModalTesting
cargo check -p cortex-tuipasses