fix(ci): allow optional secrets in publish-r2 reusable workflow#563
Merged
fix(ci): allow optional secrets in publish-r2 reusable workflow#563
Conversation
When using 'secrets: inherit' in the calling workflow (dev-deploy.yml), the secrets must be marked as required: false to avoid validation errors. The secrets are still passed through inherit and will be available at runtime from the repository/organization settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using
secrets: inheritin the calling workflow (dev-deploy.yml), the secrets must be marked asrequired: falseto avoid validation errors. The secrets are still passed through inherit and will be available at runtime from the repository/organization settings.Changes
R2_ACCESS_KEY_ID,R2_SECRET_ACCESS_KEY, andCLOUDFLARE_ACCOUNT_IDsecrets fromrequired: truetorequired: falsein thepublish-r2.ymlreusable workflow.Testing