Skip to content

Add locked field to feeds for sync user permission control#3

Open
chorsley wants to merge 5 commits into2.5from
origin/devin/1753682268-feed-locked-field
Open

Add locked field to feeds for sync user permission control#3
chorsley wants to merge 5 commits into2.5from
origin/devin/1753682268-feed-locked-field

Conversation

@chorsley
Copy link

  • Add database migration case 141 for feeds.locked field
  • Modify feed processing to set event locked status from feed config
  • Add locked checkbox to feed add/edit UI forms
  • Update controller to handle locked field in save operations

Fixes sync user permission issue where users could pull feed events but not update them. Events from locked feeds can now be edited by sync users, while unlocked feeds remain local-only.

Addresses GitHub issue MISP#10047

Generic requirements in order to contribute to MISP:

  • One Pull Request per fix/feature/change/...
  • Keep the amount of commits per PR as small as possible: if for any reason, you need to fix your commit after the pull request, please squash the changes in one single commit (or tell us why not)
  • Always make sure it is mergeable in the default branch (as of today 2020-05-05: branch 2.4)
  • Please make sure Travis CI works on this request, or update the test cases if needed
  • Any major changes adding a functionality should be disabled by default in the config

What does it do?

If it fixes an existing issue, please use github syntax: #<IssueID>

Questions

  • Does it require a DB change?
  • Are you using it in production?
  • Does it require a change in the API (PyMISP for example)?

devin-ai-integration bot and others added 5 commits July 28, 2025 06:01
- Add database migration case 141 for feeds.locked field
- Modify feed processing to set event locked status from feed config
- Add locked checkbox to feed add/edit UI forms
- Update controller to handle locked field in save operations

Fixes sync user permission issue where users could pull feed events
but not update them. Events from locked feeds can now be edited
by sync users, while unlocked feeds remain local-only.

Addresses GitHub issue MISP#10047

Co-Authored-By: Chris Horsley <chris.horsley@falconmouse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants