E2e consumer - #12
Merged
Merged
Conversation
Every bug this round shipped with a green typecheck: the stripped use client, the two missing .d.ts files, the absent stylesheet, the bare variables. They were properties of build output, which is why no lint rule would have caught them and why this checks dist. Wired into prepublishOnly, so a package that fails cannot reach the registry rather than being noticed afterwards in a tarball listing. CI runs the same command on every PR. Each check was verified by breaking it on purpose and confirming it fails. Also: 195 → 198 countries, which was wrong in four places, and both READMEs now point at fernui.vercel.app instead of localhost.
Installs the packed tarballs into a Next app that is deliberately outside the workspace globs, so nothing resolves to local source, then builds it. It is the only check that exercises the artifact a stranger receives. Both 0.1.0 bugs were invisible to typecheck and to a tarball listing, and both fail here: a missing client boundary breaks the server-component build, and a missing stylesheet fails the assertion that fern's utilities reach the built CSS. Verified by removing the stylesheet from the build and confirming it fails with a readable message.
# Conflicts: # package.json
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CI failed on the first PR because typecheck ran first. dist/ is gitignored, so a fresh clone has none, and only color-picker is aliased to source in the docs tsconfig — the other three resolve through package.json to dist/index.d.ts. Typechecking first gives six 'cannot find module' errors on a clean checkout while passing locally, where a previous build left dist/ behind. Same trap that broke the first Vercel deploy. The root build script now names the order rather than leaving it to --filter '*' to infer, so CI, Vercel and a local run cannot disagree. Vercel also runs verify now, so the deployed site cannot be built from packages that fail the invariants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.