Restore build after Chronicle 15.38.4 update#2325
Merged
Merged
Conversation
The package sweep bumped Microsoft.CodeAnalysis.CSharp, .Workspaces and .Workspaces.Common to 5.6.0. Analyzers built against 5.6.0 cannot be loaded by the Roslyn 5.3.0 compiler shipped in the pinned SDK, breaking the build locally with CS9057. Revert to 5.3.0 so analyzers load in every supported SDK; a 5.3.0 analyzer still loads fine under a newer host compiler. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Chronicle 15.38.4 added the PII member to IEventStore. The in-memory command scenario event store did not implement it, breaking the build with CS0535. Add the member following the existing unsupported-operation pattern. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
IEventStore.PIImember, and the Roslyn analyzer packages are pinned back to a version compatible with the shipped SDK compiler.Summary
The Chronicle 15.38.4 update landed on
mainwith two build breaks that only surface with the pinned SDK (CI installs a newer SDK and did not catch them):CS9057— the sweep bumpedMicrosoft.CodeAnalysis.CSharp/.Workspaces/.Workspaces.Commonto5.6.0; analyzers built against5.6.0cannot be loaded by the Roslyn5.3.0compiler in the pinned SDK. Reverted to5.3.0.CS0535— Chronicle15.38.4addedPIItoIEventStore;EventStoreForScenariodid not implement it. Added it following the existing unsupported-operation pattern.Verified locally:
dotnet clean+dotnet build -c Releaseis clean (0 warnings, 0 errors) and all 13*.Specsprojects pass.