Skip to content

Bump SharpConsoleUI to 2.5.0 and drop redundant nav invalidation#37

Closed
nickprotop wants to merge 1 commit into
Cratis:mainfrom
nickprotop:fix/invalidate-shim-removal-sharpconsoleui-2.5.0
Closed

Bump SharpConsoleUI to 2.5.0 and drop redundant nav invalidation#37
nickprotop wants to merge 1 commit into
Cratis:mainfrom
nickprotop:fix/invalidate-shim-removal-sharpconsoleui-2.5.0

Conversation

@nickprotop

Copy link
Copy Markdown
Contributor

Changed

  • Update SharpConsoleUI to 2.5.0.

Fixed

  • Remove a redundant explicit navigation invalidation in the workbench. NavigationItem.Subtitle now self-invalidates via its setter in SharpConsoleUI 2.5.0, so badge subtitle updates refresh without the extra call.

SharpConsoleUI 2.5.0 makes NavigationItem.Subtitle self-invalidate via its
setter, so the explicit _navView?.Invalidate() after updating the badge
subtitles in UpdateNavBadges is now redundant and can be removed.
@nickprotop

Copy link
Copy Markdown
Contributor Author

Closing this PR.

Bumping SharpConsoleUI to 2.5.0 manually here was a mistake on my part — apologies. The repo's daily package-update workflow already bumps NuGet versions on main automatically, so the version bump didn't need to be done by hand in a PR.

While investigating, this also revealed a side effect: changing Directory.Packages.props forces a full rebuild, which makes the Release build re-run analyzers across the whole project. That surfaced 19 pre-existing MA0206 ("remove unnecessary braces in type declaration") errors in Source/Cli/Registration/*.cs — files this PR never touched. Because the auto-update workflow builds in Debug (warnings only), these had been sitting latent on main without failing any build; the Release PR gate is the first thing to turn them into errors.

@nickprotop nickprotop closed this Jun 25, 2026
@nickprotop nickprotop deleted the fix/invalidate-shim-removal-sharpconsoleui-2.5.0 branch June 25, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant