feat(delegation): derive pause proposal_id from action hash for idemp…#479
Merged
Baskarayelu merged 3 commits intoJun 3, 2026
Conversation
…otency - Replace counter-based PauseProposalCounter with deterministic hash(action, epoch) - Add PROPOSAL_EPOCH_SIZE constant (100 ledgers ~8 min) with tradeoff docs - derive_proposal_id: SHA-256 of (action_u32 ++ epoch_u32), first 8 bytes as u64 - Idempotent: same action+epoch converges to one proposal, votes accumulate - Add get_proposal_by_legacy_id compatibility shim for old counter-based IDs - Fix executed detection for hash-derived proposals via surviving approval keys - Fix credence_errors duplicate discriminants (StorageCapReached=224, DomainMismatch=225) - Add 6 test cases: idempotency, epoch difference, simultaneous, boundary, accumulation, legacy fetch
|
@K1NGD4VID Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
K1NGD4VID
force-pushed
the
feature/delegation-deterministic-proposal-id
branch
from
63993e4 to
bf218b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…otency
closes #437