Skip to content

docs: add Dutch auction implementation notes and reference issue #351#434

Closed
olaleyeolajide81-sketch wants to merge 0 commit into
Creditra:mainfrom
olaleyeolajide81-sketch:Add-Dutch-auction-descending-price-mode1
Closed

docs: add Dutch auction implementation notes and reference issue #351#434
olaleyeolajide81-sketch wants to merge 0 commit into
Creditra:mainfrom
olaleyeolajide81-sketch:Add-Dutch-auction-descending-price-mode1

Conversation

@olaleyeolajide81-sketch
Copy link
Copy Markdown
Contributor

This PR adds documentation for the Dutch auction implementation and creates a formal reference to issue #351.

Summary

The Dutch auction descending-price mode requested in issue #351 was fully implemented and merged via PR #425. This PR adds implementation notes and formally references the issue so it can be closed by maintainers.

Changes Made

Issue Resolution

Closes #351

The actual implementation includes:

  • AuctionMode enum (English/Dutch) in types.rs
  • Extended AuctionConfig with Dutch parameters (dutch_start_price, dutch_floor_price)
  • Overflow-safe compute_dutch_price function for monotone decreasing price calculation
  • Updated init_auction to accept mode and Dutch parameters with validation
  • Updated place_bid to support Dutch auction first-bid settlement
  • Comprehensive Dutch auction tests covering price at start, mid, and floor

All acceptance criteria have been met:
✅ Price decays monotonically and clamps at floor
✅ First qualifying bid settles the auction
✅ English mode behavior unchanged when mode is default

Test plan

@olaleyeolajide81-sketch olaleyeolajide81-sketch force-pushed the Add-Dutch-auction-descending-price-mode1 branch from bf25c64 to bce8dc6 Compare June 1, 2026 05:09
@olaleyeolajide81-sketch
Copy link
Copy Markdown
Contributor Author

close issue #351 with a reference to PR #425

@olaleyeolajide81-sketch
Copy link
Copy Markdown
Contributor Author

This PR is being linked to issue #351 to create a formal connection.

Issue #351 requested adding Dutch auction descending-price mode to the auction_contract. This feature was successfully implemented and merged via PR #425.

Implementation Status

  • ✅ Price decays monotonically and clamps at floor
  • ✅ First qualifying bid settles the auction
  • ✅ English mode behavior unchanged when mode is default

Related Links

This PR creates the formal link between issue #351 and the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Dutch-auction descending-price mode to auction_contract for faster default recovery

1 participant