docs: add Dutch auction implementation notes and reference issue #351#434
Closed
olaleyeolajide81-sketch wants to merge 0 commit into
Closed
Conversation
bf25c64 to
bce8dc6
Compare
Contributor
Author
Contributor
Author
|
This PR is being linked to issue #351 to create a formal connection. Issue #351 requested adding Dutch auction descending-price mode to the auction_contract. This feature was successfully implemented and merged via PR #425. Implementation Status
Related Links
This PR creates the formal link between issue #351 and the implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the Dutch auction implementation and creates a formal reference to issue #351.
Summary
The Dutch auction descending-price mode requested in issue #351 was fully implemented and merged via PR #425. This PR adds implementation notes and formally references the issue so it can be closed by maintainers.
Changes Made
Issue Resolution
Closes #351
The actual implementation includes:
All acceptance criteria have been met:
✅ Price decays monotonically and clamps at floor
✅ First qualifying bid settles the auction
✅ English mode behavior unchanged when mode is default
Test plan