Skip to content

fix: Filter unknown property while deserializing #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VitSoonYoung wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Filter unknown property while deserializing #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions addons/godot_object_serializer/object_serializer.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,22 @@ static func _get_entry(name: StringName = "", script: Script = null) -> _ScriptR
return entry

return null


static func _get_class_properties(instance: Variant) -> Array[String]:
var results: Array[String] = []

if not instance.has_method(&"get_property_list"):
assert(false, "Invalid instance")
return results

for property: Dictionary in instance.get_property_list():
results.append(property.name)

# get_property_list() returns 3 first elements as infomation of the scripts
# they're redundant in this case, eg:
# ["RefCounted", "script", "recruit_data.gd", "unit_id", "title", "reroll_count"]
return results.slice(3)


class _ScriptRegistryEntry:
Expand Down Expand Up @@ -127,6 +143,8 @@ class _ScriptRegistryEntry:
instance = script_type.new.callv(value[ObjectSerializer.args_field])
else:
instance = script_type.new()

var included_properties: Array[String] = ObjectSerializer._get_class_properties(instance)

var excluded_properties: Array[String] = []
if instance.has_method("_get_excluded_properties"):
Expand All @@ -140,6 +158,7 @@ class _ScriptRegistryEntry:
if (
key == ObjectSerializer.type_field
or key == ObjectSerializer.args_field
or not included_properties.has(key)
or excluded_properties.has(key)
or partial.has(key)
):
Expand Down