feat: Auto refresh (#130)#141
Draft
peso wants to merge 9 commits into
Draft
Conversation
Instead of relying on access to DetailsPanel.scroll, provide a setter function.
The scrollbar is used automatically, and less boilerplate code is needed for drawing in all the tabs.
Increase code clarity and prepare for multiple events per draw
Improve code clarity.
This makes it possible to keep lazyjj in one window, and working with jj in another. Every jj command will cause lazyjj to update. UNSTABLE Sometimes an external and an internal jj operation runs at the same time. This causes duplicate branches to appear. On the positive side, it is excellent for testing concurrency issues with jj. TRY: Add a --no-workspace-update flag so the refresh can run without updating .jj. TRY: Let focus lost/gained control when updates are allowed.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #130
Note that the code have been somewhat unstable for concurrent jj operations, which I hope is fixed now.
Please test and provide feedback on stability.
The issue manifests with a crash of lazyjj and jj asks you to run "jj workspace update-stale"
Also, the current PR contains another PR which should be removed before merge.