fix: send file paths as filesets#183
Merged
Merged
Conversation
dotdash
reviewed
Nov 24, 2025
| }; | ||
|
|
||
| let mut args = vec!["diff", "-r", head.commit_id.as_str(), path]; | ||
| let fileset = format!("file:\"{}\"", path); |
Collaborator
There was a problem hiding this comment.
Would this break with filenames containing double quotes?
Contributor
Author
There was a problem hiding this comment.
Thank you!
Yes it did break if a file contained double quotes. I fixed it now 👍
dotdash
approved these changes
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks again for the time and effort you've put into lazyjj !
This fixes an error where if a path contains
:jj tries to parse it as a fileset. The error is this:This fixes it by prefixing the path with
path:so it "Matches cwd-relative path prefix (file or files under directory recursively.)"I have been using daily a fork with this commit for over a week and found no problems with it