fix: Fix crash & update UI when current head no longer exists#188
Merged
Conversation
Edgpaez
changed the title
dotdash
approved these changes
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing a fetch that removes the current head (for instance because you were in a branch that is merged) or issuing a jj command in a different window that causes the current head to disappear (because it was empty), we currently crash when trying to find the latest version of that head.
The problem is that
jj log --no-graph -r luwtfails ifluwtdoes not exist. However, after #181 we dojj log --no-graph -r 'change_id(luwt)'that simply returns empty ifluwtdoes not exists.This fixes this by checking the output was not empty and using
set_headto update the UI