Update details pane on focus only if content changes#193
Merged
Conversation
Edgpaez
changed the title
dotdash
reviewed
Jan 11, 2026
Edgpaez
force-pushed
the
update-details-pane
branch
from
January 13, 2026 16:36
ade6ba2 to
fa8c503
Compare
dotdash
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #189
As explained there, when doing a push or a fetch that didn't change the change_id, the pane view (that shows the jj show view in the right) was not refreshed. This meant that even though the push finished you wouldn't see the bookmark from the remote being added to the change.
This PR makes sure
sync_head_outputalways callsrefresh_head_output.This PR also addresses @dotdash's feedback and only updates the details pane if the contents changed. This way you don't lose the scroll position unless the output of
jj showis now different.