Skip to content

Replace corepack with pnpm/action-setup - #250

Merged
mraible merged 1 commit into
CrowdStrike:mainfrom
mraible:remove-corepack
Aug 14, 2026
Merged

Replace corepack with pnpm/action-setup#250
mraible merged 1 commit into
CrowdStrike:mainfrom
mraible:remove-corepack

Conversation

@mraible

@mraible mraible commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The pnpm team recommends against using corepack to install pnpm, since it wraps pnpm in a JS shim and is redundant once pnpm resolves its own version from the packageManager field. The Node.js TSC has also voted to stop bundling corepack, though it still ships as of Node 26, so this is cleanup rather than anything urgent.

pnpm/action-setup is the officially supported way to install pnpm in GitHub Actions. The pnpm version still comes from the packageManager field, so no version is duplicated into the workflows and there is nothing new to keep in sync.

One tradeoff worth naming: corepack verified the downloaded pnpm tarball against the +sha512 hash committed in packageManager, and pnpm/action-setup does not. It passes the version to pnpm install, where the hash is treated as semver build metadata and ignored, so the tarball is verified against the registry's own integrity metadata instead. Since packageManager pins an exact version and npm versions are immutable, the practical exposure is narrow, but it is a real difference from the current behavior.

@changeset-bot

changeset-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0f7cfa6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mraible
mraible requested a review from a team August 14, 2026 14:06
@mraible
mraible enabled auto-merge (squash) August 14, 2026 14:13
The pnpm team recommends against using corepack to install pnpm. The Node.js TSC has also voted to stop bundling corepack, though it still ships as of Node 26.

pnpm/action-setup is the officially supported way to install pnpm in GitHub Actions. The pnpm version continues to come from the packageManager field in package.json, so there is no version duplicated into the workflows.

See https://x.com/pnpmjs/status/2087964982289854928
@mraible
mraible merged commit 2c7baae into CrowdStrike:main Aug 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants