Add log level switch#54
Open
stephenwithav wants to merge 3 commits into
Open
Conversation
CRUNCHY_LOG_LEVEL is the environment variable; log-level the switch. If --debug is included as a flag, it will supercede --log-level.
abrightwell
requested changes
Aug 13, 2018
abrightwell
left a comment
abrightwell
left a comment
Member
There was a problem hiding this comment.
Overall, I'm supportive of adding a "log level" configuration option. I think this makes sense. The part that I'm less enthused about is the potential confusion that having a separate 'debug' configuration option might create. Minor changes requested.
| LogLevel = flags.FlagInfo{ | ||
| Namespace: "general", | ||
| Name: "log-level", | ||
| EnvVar: "CRUNCHY_LOG_LEVEL", |
Member
There was a problem hiding this comment.
Would need to be CRUNCHY_WATCH_LOG_LEVEL to maintain consistency with the namespace-ing of the application's configuration parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.