Skip to content

Fix accessibility: Open keyboard on TalkBack double-tap #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mieciuJP wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix accessibility: Open keyboard on TalkBack double-tap #1074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions app/src/main/java/com/philkes/notallyx/presentation/view/misc/EditTextWithWatcher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.philkes.notallyx.presentation.view.misc

import android.content.Context
import android.os.Build
import android.text.Editable
import android.text.TextWatcher
import android.text.method.KeyListener
Expand All @@ -17,6 +16,8 @@ open class EditTextWithWatcher(context: Context, attrs: AttributeSet) :
private var onSelectionChange: ((selStart: Int, selEnd: Int) -> Unit)? = null
private var keyListenerInstance: KeyListener? = null

private var isEditableMode = true

override fun onSelectionChanged(selStart: Int, selEnd: Int) {
super.onSelectionChanged(selStart, selEnd)
onSelectionChange?.invoke(selStart, selEnd)
Expand All @@ -35,6 +36,7 @@ open class EditTextWithWatcher(context: Context, attrs: AttributeSet) :
}

fun setCanEdit(value: Boolean) {
isEditableMode = value
if (!value) {
clearFocus()
}
Expand All @@ -44,19 +46,26 @@ open class EditTextWithWatcher(context: Context, attrs: AttributeSet) :
isFocusable = value
isFocusableInTouchMode = value
setTextIsSelectable(true)
}

override fun onFocusChanged(
focused: Boolean,
direction: Int,
previouslyFocusedRect: android.graphics.Rect?,
) {
super.onFocusChanged(focused, direction, previouslyFocusedRect)
if (focused && isEditableMode) {
context.showKeyboard(this)
}
}

if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O_MR1) {
setOnClickListener {
if (value) {
context.showKeyboard(this)
}
}
setOnFocusChangeListener { v, hasFocus ->
if (hasFocus && value) {
context.showKeyboard(this)
}
}
override fun performClick(): Boolean {
val result = super.performClick()
if (isEditableMode) {
context.showKeyboard(this)
return true
}
return result
}

@Deprecated(
Expand Down