fix: contain RISE combat layout - #21
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CryptoMickle
force-pushed
the
fix/rise-combat-layout-overlap
branch
from
August 28, 2026 01:03
ef0fdf8 to
406b2d6
Compare
CryptoMickle
marked this pull request as ready for review
August 28, 2026 01:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PR #63 / commit
7ae8793introduced the shared 3:2 desktop combat grid. Practice Mode uses an absolutely filling Next Image and an explicitly full-width stage, while the onchain view uses a regular image element. The image's intrinsic 16:9 size could therefore widen the left grid track and cover or displace enemy information.Scope
Layout-only change in
frontend/app/page.tsx. No game state, combat mechanics, contract calls, wallet flow or VRF behavior changed.Validation
npm run lint: 0 errors, 15 pre-existing warnings./node_modules/.bin/tsc --noEmit/rise-testnet-demosmoke test against the public RISE Testnet deployment; no wallet connection or transaction initiatedBuild note
The sandboxed local Turbopack build cannot bind its internal PostCSS worker port. A webpack fallback reaches an existing Wagmi optional-module resolution issue. GitHub Frontend CI is the authoritative production-build check for this commit.