Skip to content

fix: contain RISE combat layout - #21

Merged
CryptoMickle merged 1 commit into
mainfrom
fix/rise-combat-layout-overlap
Aug 28, 2026
Merged

fix: contain RISE combat layout#21
CryptoMickle merged 1 commit into
mainfrom
fix/rise-combat-layout-overlap

Conversation

@CryptoMickle

Copy link
Copy Markdown
Owner

Summary

  • prevent the onchain RISE monster image from expanding its desktop grid track
  • give both combat columns an explicit zero minimum
  • align the onchain monster stage width contract with Practice Mode

Root cause

PR #63 / commit 7ae8793 introduced the shared 3:2 desktop combat grid. Practice Mode uses an absolutely filling Next Image and an explicitly full-width stage, while the onchain view uses a regular image element. The image's intrinsic 16:9 size could therefore widen the left grid track and cover or displace enemy information.

Scope

Layout-only change in frontend/app/page.tsx. No game state, combat mechanics, contract calls, wallet flow or VRF behavior changed.

Validation

  • responsive layout checked at 375, 768, 1024, 1280, 1536 and 1920 px
  • mobile layouts stack without horizontal overflow
  • desktop layouts preserve the intended 60/40 columns without overlap
  • npm run lint: 0 errors, 15 pre-existing warnings
  • ./node_modules/.bin/tsc --noEmit
  • local /rise-testnet-demo smoke test against the public RISE Testnet deployment; no wallet connection or transaction initiated

Build note

The sandboxed local Turbopack build cannot bind its internal PostCSS worker port. A webpack fallback reaches an existing Wagmi optional-module resolution issue. GitHub Frontend CI is the authoritative production-build check for this commit.

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
delveworn Ready Ready Preview Aug 28, 2026 1:04am

@CryptoMickle
CryptoMickle force-pushed the fix/rise-combat-layout-overlap branch from ef0fdf8 to 406b2d6 Compare August 28, 2026 01:03
@CryptoMickle
CryptoMickle marked this pull request as ready for review August 28, 2026 01:06
@CryptoMickle
CryptoMickle merged commit 279a8e8 into main Aug 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant