Update ampinstmgr.service for docker#1356
Open
BroOtti wants to merge 1 commit intoCubeCoders:masterfrom
Open
Conversation
If docker.service is present ampinstmgr.service should only start after docker.service is running. This way ampinstmgr.service is also stopped before docker.service is stopped on shutdown which allows a graceful stop.
3 tasks
Contributor
|
This seems a reasonable change. But I am not sure that the files in this GitHub are ultimately used as a source for the units included with ampinstmgr itself. |
Author
|
At least it's visible here for others and changes can be made where they need to be made for this :D |
Contributor
|
Right, just saying it probably wouldn't have much visibility here otherwise |
kdallas
reviewed
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If docker.service is present, ampinstmgr.service should only start after docker.service is running. This way ampinstmgr.service is also stopped before docker.service is stopped on shutdown which allows a graceful stop.
This also helps to solve a part of issue #1019