Added maxTags property in a row #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: since user specifically wants said number of tags in one line, the tag won't be place in new line if it exceeds the screen width.
moreakshay
changed the title
moreakshay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to specify maximum number of tags in a row.
In earlier version when TagView's width was set to wrap_content it only showed 1 tag per line.
which proved unproductive when used in any horizontal scrollable view.
In the above example maxTags is set to 2.
Default is 0, which will render normal/default behavior
Notice how "Sudan" and "Suriname" is on next line even when there is space after their previous tag "Sri Lanka".
Note: since the user specifically wants said number of tags in one line it will draw the tag regardless it fits in the screen.
This property doesn't affect any other functionality of the project.
No major changes to the original code.
code written/changed in drawTags() method.
changed code lines are commented .