Skip to content

Conversation

@CyAScott
Copy link
Owner

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This is a major refactoring effort that modernizes and standardizes the PolyBus messaging framework across TypeScript, Python, and .NET implementations. The refactoring focuses on improving API consistency, simplifying interfaces, and enhancing error handling.

Key changes:

  • Renamed core methods and properties for clarity (addOutgoingMessageadd, incomingHandlersincomingPipeline)
  • Split transaction factories into separate incoming/outgoing factories
  • Changed Messages API from returning nullable types to throwing specific errors
  • Restructured in-memory transport into broker/endpoint pattern
  • Simplified JSON handlers by removing configuration flags
  • Added new error types for better error categorization

Reviewed changes

Copilot reviewed 104 out of 104 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
TypeScript transaction files Renamed addOutgoingMessage to add, simplified endpoint resolution
TypeScript message files Added messageInfo property, changed Messages methods to throw errors
TypeScript transport interface Renamed send to handle, added deadLetterEndpoint, renamed properties
TypeScript in-memory transport Split into InMemoryMessageBroker and InMemoryEndpoint classes
TypeScript error handlers Renamed delay to delayIncrement, improved logging
TypeScript JSON handlers Removed throwOnMissingType and throwOnInvalidType flags
TypeScript tests Simplified and updated to match new APIs
Python implementation Mirrors TypeScript changes with Python conventions
.NET implementation Mirrors TypeScript changes with C# conventions
Documentation Updated README files to remove detailed project structure sections

@CyAScott CyAScott merged commit 1674abf into main Nov 30, 2025
12 checks passed
@CyAScott CyAScott deleted the refactor branch November 30, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants