-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This is a major refactoring effort that modernizes and standardizes the PolyBus messaging framework across TypeScript, Python, and .NET implementations. The refactoring focuses on improving API consistency, simplifying interfaces, and enhancing error handling.
Key changes:
- Renamed core methods and properties for clarity (
addOutgoingMessage→add,incomingHandlers→incomingPipeline) - Split transaction factories into separate incoming/outgoing factories
- Changed Messages API from returning nullable types to throwing specific errors
- Restructured in-memory transport into broker/endpoint pattern
- Simplified JSON handlers by removing configuration flags
- Added new error types for better error categorization
Reviewed changes
Copilot reviewed 104 out of 104 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| TypeScript transaction files | Renamed addOutgoingMessage to add, simplified endpoint resolution |
| TypeScript message files | Added messageInfo property, changed Messages methods to throw errors |
| TypeScript transport interface | Renamed send to handle, added deadLetterEndpoint, renamed properties |
| TypeScript in-memory transport | Split into InMemoryMessageBroker and InMemoryEndpoint classes |
| TypeScript error handlers | Renamed delay to delayIncrement, improved logging |
| TypeScript JSON handlers | Removed throwOnMissingType and throwOnInvalidType flags |
| TypeScript tests | Simplified and updated to match new APIs |
| Python implementation | Mirrors TypeScript changes with Python conventions |
| .NET implementation | Mirrors TypeScript changes with C# conventions |
| Documentation | Updated README files to remove detailed project structure sections |
No description provided.