Conversation
curlyLasagna
requested review from
Cwagne17,
Copilot,
dsoto18 and
joaquinVill
dsoto18
left a comment
dsoto18
left a comment
There was a problem hiding this comment.
Lint kinda went crazy here
There was a problem hiding this comment.
Pull request overview
Adds a new /organizations proxy route under the CLARK router and removes the now-sunset CARD search endpoint for organizations.
Changes:
- Added CLARK
GET /organizationsproxy route via a new Organization router/routes module. - Registered the new CLARK OrganizationRouteHandler in
clark.router.ts. - Removed CARD
GET /organizationsfromsrc/modules/card/search/search.routes.tsand applied small formatting fixes (trailing commas) in several route config files.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/modules/clark/utility-module/utility.routes.ts | Trailing-comma formatting in route config. |
| src/modules/clark/standard-guidelines-module/standard-guidelines.routes.ts | Trailing-comma formatting in route config. |
| src/modules/clark/organization/organization.routes.ts | Introduces CLARK GET /organizations route definition. |
| src/modules/clark/organization/organization.router.ts | Adds proxy router wiring for organization routes to CLARK service. |
| src/modules/clark/metric-module/metrics.routes.ts | Trailing-comma formatting in route config. |
| src/modules/clark/learning-object-module/search.routes.ts | Trailing-comma formatting in route config. |
| src/modules/clark/learning-object-module/revisions.routes.ts | Trailing-comma formatting in route config. |
| src/modules/clark/clark.router.ts | Registers OrganizationRouteHandler in the CLARK router. |
| src/modules/clark/chatbot-module/chatbot.routes.ts | Whitespace/trailing-comma formatting in route config. |
| src/modules/clark/chatbot-module/chatbot.router.ts | Formatting-only change. |
| src/modules/card/search/search.routes.ts | Removes CARD GET /organizations route from search routes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/modules/clark/clark.router.ts
Outdated
| import { AuthRouteHandler } from "./auth-module/auth.router"; | ||
| import { FileRouteHandler } from "./file-module/file.router"; | ||
| import { ChatBotRouteHandler } from "./chatbot-module/chatbot.router"; | ||
| import { OrganizationRouteHandler } from "./organization/organization.router"; |
There was a problem hiding this comment.
Within ClarkRouteHandler, every other sub-router import follows a *-module folder convention (e.g., ./user-module/..., ./utility-module/...), but this PR introduces ./organization/.... For consistency and easier navigation, consider renaming the folder to organization-module (and updating the import), or aligning the naming across Clark modules if organization is intentionally different.
src/modules/clark/clark.router.ts
Outdated
| import { AuthRouteHandler } from "./auth-module/auth.router"; | ||
| import { FileRouteHandler } from "./file-module/file.router"; | ||
| import { ChatBotRouteHandler } from "./chatbot-module/chatbot.router"; | ||
| import { OrganizationRouteHandler } from "./organization/organization.router"; |
…-organizations-suggest-domain gateway route addition
…k-client-user-organization Chore/sc 38695/update the clark client user organization
…ch-organizations gateway addition for PATCH organizations
…t-organizations-endpoint-for gateway route addition for POST /organizations
|
Sending out this PR is what will make the service changes active, double check it meets the requirements detailed in this story before merging in https://app.shortcut.com/clarkcan/story/38766/clark-gateway-organization-routes-pr-main-branch |
What this PR does / why we need it
This PR adds the /organizations route for CLARK and sunsets the CARD route
Important Edit
Sending out this PR is what will make the service changes active, double check it meets the requirements detailed in this story before merging in https://app.shortcut.com/clarkcan/story/38766/clark-gateway-organization-routes-pr-main-branch