Extract embedded JPEG previews for fast interim thumbnails#1128
Open
bennetthermanoff wants to merge 1 commit into
Open
Extract embedded JPEG previews for fast interim thumbnails#1128bennetthermanoff wants to merge 1 commit into
bennetthermanoff wants to merge 1 commit into
Conversation
This commit expands the thumbnail generation system to include two new tiers of embedded JPEG previews: For RAW files: - "Tiny" previews are extracted from the first 64K of a file - These are also scanned for any orientation metadata which is applied if present. - "Embedded" previews extract the full embedded JPEG preview - These can be significantly larger than the tiny previews, on Fuji RAF files for example they can be ~1MB in size, but they are still much faster to decode than generating a thumbnail from the RAW data. For JPEG files: - Only "Tiny" previews are extracted This commit also adds a new setting (default enabled) to allow users to disable the use of embedded JPEG thumbnails on RAWs if they prefer. From a usability and first time user experience perspective this is a huge improvement especially when browsing large libraries of RAW and JPEG files. Other RAW editors utilize these embedded previews so I believe users will understand that final thumbnails will be more accurate.
Contributor
|
Awesome! Was this really not implemented already?! I surely thought it was. Great work! |
|
Maybe you could indicate that the real thumbnail is being generated with a little loading icon or something? Any icon/indication that would tell the user the thumbnail they're seeing is not the final one, basically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit expands the thumbnail generation system to include two new tiers of embedded JPEG previews:
For RAW files:
For JPEG files:
This commit also adds a new setting (default enabled) to allow users to disable the use of embedded JPEG thumbnails on RAWs if they prefer.
From a usability and first time user experience perspective this is a huge improvement especially when browsing large libraries of RAW and JPEG files. Other RAW editors utilize these embedded previews so I believe users will understand that final thumbnails will be more accurate.
Description
Type of Change
Changes Made
Backend:
Frontend:
Screenshots/Videos
Screencast.From.2026-05-03.20-42-36.mp4
Testing
Test Configuration:
Checklist
AI Disclaimer:
Please state the involvement of AI in this PR:
AI was instrumental in writing the actual extraction logic of JPEG previews.