chore: remove unused dependencies, upgrade tooling, and fix Dockerfile#530
chore: remove unused dependencies, upgrade tooling, and fix Dockerfile#530at-besa wants to merge 8 commits into
Conversation
Release V1.1.8
Release V1.1.9
Bump version to 1.1.10 in package.json and update SQL queries for par…
- Remove 17 unused packages (antd, sequelize, passport, passport-jwt, github-api, axios-cache-interceptor, http-proxy-middleware, config, dns-cache, dottie, randomcolor, semver, react-scripts, check-valid-url, dottie, and @testing-library/* leftovers from CRA template) - Replace github-api (abandoned, bundled axios@0.21.4 CVE) with direct axios call to GitHub Contents API — resolves 1 high severity vulnerability - Upgrade to Vite 8 + @vitejs/plugin-react-swc@4, rewrite vite.config.js with rolldown-compatible manualChunks function and loadEnv for JS_BASE_URL - Update Dockerfile to node:26-bookworm-slim with apt-get upgrade, reducing image CVEs from 3 high to 2 high - Drop CRA boilerplate: App.test.jsx, setupTests.js, eslintConfig block
Was previously pulled in transitively via passport-jwt; removing that package left it missing at runtime.
|
did a new pr, but keep in mind that unstable is some commits behind main |
|
Thanks @at-besa , im in the middle of reviewing it now. Where you able to run |
added proxy to env.js file thats served from the api with dynamic env variables minor css fix that th compiler wasc omplaining about
|
i added some quick fixes just to the get it semi functional, but i think you my need to investigate what change was made that seems to have broken how the styling is applied |
|
im looking into it, sorry i did not run the build version at the time, but i see the problem now. Didn't expect that the dev will run fine but build not -.- |
- Rename variables.module.css → variables.css: Vite 8/rolldown handled .module.css @imports differently, causing :root variables to not apply globally in production builds → broken colors and backgrounds - Import variables.css, width_breakpoint_css and radius_breakpoint_css directly in index.jsx so they are guaranteed in the main bundle - Use html body selector instead of body for dark theme to out-specificate Bootstrap without !important - Scope navbar .active → .navitem.active to prevent purple bleed-through onto Bootstrap tab components in settings - Improve vite.config.js manualChunks: split @mui/icons-material and @mui/x-* into separate chunks to reduce vendor-mui chunk size
revert upstream changes
|
works like a charm now :) |
|
Hey @at-besa , yea this looks better, the styling isnt broken anymore, but the rollup issue is still occurring on build. eg I tried fixing it but the error then shifts to a different file, eg after i grouped the recharts lib into vendor-misc I think youl need to bundle some of the libraries into the same file so all the relevant imports for each library is present in the same file. Network times and file sizes can cause some files to be delayed which means some functions arent loaded yet when it tries to load the page |
|
i'll have a look on this asap tomorrow 👌 |
2 participants
re-created PR to unstable branch