fix(server): advance campaign to InProduction on first tranche release (#173) - #176
Open
trenysx wants to merge 1 commit into
Open
fix(server): advance campaign to InProduction on first tranche release (#173)#176trenysx wants to merge 1 commit into
trenysx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #173
Per the escrow contract's state machine, the first tranche release transitions a campaign from
FundedtoInProduction(seerelease_trancheincontracts/production_escrow/src/lib.rs, which accepts bothFundedandInProduction). The indexer'shandleTrancheReleasedonly created aTrancherow and upserted the recipient user, leavingCampaign.statusstuck atFundeduntilHarvestReportedfired.Change
In
server/src/indexer/parsers/event-parser.service.ts,handleTrancheReleasednow performs a conditionalupdateManythat advancesstatustoInProductiononly when the current stored status isFunded:where: { id: campaignId, status: 'Funded' }data: { status: 'InProduction' }Because the
whereclause includes the current status, a second/third tranche release on an already-InProductioncampaign matches zero rows and is a no-op rather than an unnecessary write.Tests
Added a
TrancheReleased -> InProduction statusblock toevent-parser.service.spec.ts:Fundedcampaign toInProduction(asserts the exact conditional update call).Funded-guarded update (matching count 0 simulates an already-released campaign), proving later releases cannot reset or duplicate-write the status.All 47 unit tests in
event-parser.service.spec.tspass;tsc --noEmitandeslintare clean for the changed files.