Skip to content

chore: Specify IsPackable=false on Directory.Build.props, explicitly true for target packages. #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitarrapc merged 1 commit into from
Sep 24, 2025
Merged

chore: Specify IsPackable=false on Directory.Build.props, explicitly true for target packages. #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<NoWarn>$(NoWarn);CS1591</NoWarn>

<!-- NuGet Packaging -->
<IsPackable>false</IsPackable>
<PackageVersion>$(Version)</PackageVersion>
<Authors>Cysharp</Authors>
<Company>Cysharp</Company>
Expand All @@ -20,6 +21,8 @@
</PropertyGroup>

<ItemGroup>
<None Include="$(MSBuildThisFileDirectory)Icon.png" Pack="true" PackagePath="\" />
<None Include="$(MSBuildThisFileDirectory)README.md" Pack="true" PackagePath="\" />
<EmbeddedResource Include="$(MSBuildThisFileDirectory)LICENSE" />
</ItemGroup>
</Project>
1 change: 0 additions & 1 deletion sandbox/ConsoleController/ConsoleController.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion sandbox/ConsoleMultipleWorker/ConsoleMultipleWorker.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion sandbox/ConsoleWorker/ConsoleWorker.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion sandbox/MinimalEcho/MinimalEcho.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<TargetFramework>net8.0</TargetFramework>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
9 changes: 3 additions & 6 deletions sandbox/MinimalMagicOnion/MinimalMagicOnion.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,13 @@
<TargetFramework>net8.0</TargetFramework>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<IsPackable>false</IsPackable>
</PropertyGroup>
<ItemGroup>
<Protobuf Include="Protos\greet.proto" GrpcServices="Server" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="ZLogger" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Grpc.AspNetCore" />
<PackageReference Include="ZLogger" Version="1.6.1" />
<PackageReference Include="Grpc.AspNetCore" Version="2.40.0" />
<PackageReference Include="MagicOnion" Version="7.0.2" />
</ItemGroup>
</Project>
</Project>
1 change: 0 additions & 1 deletion sandbox/MinimumGrpc/MinimumGrpc.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<TargetFramework>net8.0</TargetFramework>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion sandbox/RestClient/RestClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion sandbox/RunBoth/RunBoth.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
6 changes: 1 addition & 5 deletions src/DFrame.Controller/DFrame.Controller.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@
<IsPackable>true</IsPackable>
</PropertyGroup>

<ItemGroup>
<None Include="..\..\Icon.png" Pack="true" PackagePath="/" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="MagicOnion" />
<PackageReference Include="MessagePipe" />
Expand All @@ -27,4 +23,4 @@
</PackageReference>
</ItemGroup>

</Project>
</Project>
4 changes: 0 additions & 4 deletions src/DFrame.RestSdk/DFrame.RestSdk.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@
<IsPackable>true</IsPackable>
</PropertyGroup>

<ItemGroup>
<None Include="..\..\Icon.png" Pack="true" PackagePath="/" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="MessagePack" />
<PackageReference Include="UnitGenerator">
Expand Down
6 changes: 1 addition & 5 deletions src/DFrame.Worker/DFrame.Worker.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
<IsPackable>true</IsPackable>
</PropertyGroup>

<ItemGroup>
<None Include="..\..\Icon.png" Pack="true" PackagePath="/" />
</ItemGroup>

<ItemGroup>
<Compile Include="..\DFrame.Controller\HubDefinitions.cs" Link="HubDefinitions.cs" />
</ItemGroup>
Expand All @@ -41,4 +37,4 @@
<Target Name="PostBuild" AfterTargets="PostBuildEvent">
<Copy SourceFiles="@(TargetFiles1)" DestinationFiles="$(DestinationRoot)\%(RecursiveDir)%(Filename)%(Extension)" SkipUnchangedFiles="true" />
</Target>
</Project>
</Project>
6 changes: 1 addition & 5 deletions src/DFrame/DFrame.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,9 @@
<IsPackable>true</IsPackable>
</PropertyGroup>

<ItemGroup>
<None Include="..\..\Icon.png" Pack="true" PackagePath="/" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\DFrame.Controller\DFrame.Controller.csproj" />
<ProjectReference Include="..\DFrame.Worker\DFrame.Worker.csproj" />
</ItemGroup>

</Project>
</Project>
1 change: 0 additions & 1 deletion tests/DFrame.Tests/DFrame.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<!--<Nullable>enable</Nullable>-->
<NoWarn>$(NoWarn);8632</NoWarn> <!-- CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. -->
<ImplicitUsings>enable</ImplicitUsings>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
Loading