feat: Add option to hide Permanent Island in landscape orientation#235
Open
ansjdev wants to merge 1 commit into
Open
feat: Add option to hide Permanent Island in landscape orientation#235ansjdev wants to merge 1 commit into
ansjdev wants to merge 1 commit into
Conversation
- Add hidePermanentIslandLandscape settings preference and UI switch - Update PermanentIslandManager to dismiss the empty island when in landscape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new toggle setting in the Permanent Island configuration screen to allow users to automatically hide the empty permanent island when the device is in landscape mode.
Motivation
When playing games, watching videos, or using full-screen apps in landscape mode, the permanent empty island can overlay content unnecessarily and cause visual clutter. Hiding it in landscape improves the user experience during full-screen or landscape-specific activities.
Changes
hidePermanentIslandLandscapepreference key and synchronous/reactive settings flows.PermanentIslandManagerto dynamically evaluate the device configuration and hide the permanent island when landscape orientation is detected.NotificationReaderServiceto update the permanent island state immediately when the device rotates.Visual Changes (UI/UX)