Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/test_code.sh
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
#!/bin/bash

# Script to run tests to account for wonkiness of periodic mac failures.
args=" -s --cov dascore --cov-append --cov-report=xml"
args="tests -s --cov dascore --cov-append --cov-report=xml"
if [[ "$1" == "doctest" ]]; then
args="dascore --doctest-modules"
fi
if [[ "$1" == "profile" ]]; then
args="benchmarks --codspeed"
fi

exit_code=0

Expand Down
36 changes: 36 additions & 0 deletions .github/workflows/profile.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# An action for running DASCore's performance benchmarks.
name: CodSpeed Benchmarks

on:
push:
branches:
- master
pull_request:
workflow_dispatch:

env:
python_version: "3.13"

jobs:
benchmarks:
name: Run benchmarks
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-tags: "true"
fetch-depth: '0'

- uses: actions/setup-python@v6
with:
python-version: ${{ env.python_version }}

- name: Install dependencies
run: pip install ".[profile]"

- name: Run benchmarks
uses: CodSpeedHQ/action@v4
with:
mode: instrumentation
run: ./.github/test_code.sh profile
token: ${{ secrets.CODSPEED_TOKEN }} # Optional for public repos
Comment on lines +24 to +36

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Use a published actions/setup-python release.

actions/setup-python@v6 hasn't been published, so the workflow will fail with “Failed to resolve action”. Switch to the latest shipping major (@v5) to keep the job runnable.

Apply this diff:

-      - uses: actions/setup-python@v6
+      - uses: actions/setup-python@v5
         with:
           python-version: ${{ env.python_version }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- uses: actions/setup-python@v6
with:
python-version: ${{ env.python_version }}
- name: Install dependencies
run: pip install ".[test]"
- name: Run benchmarks
uses: CodSpeedHQ/action@v4
with:
mode: instrumentation
run: pytest benchmarks/ --codspeed
token: ${{ secrets.CODSPEED_TOKEN }} # Optional for public repos
- uses: actions/setup-python@v5
with:
python-version: ${{ env.python_version }}
- name: Install dependencies
run: pip install ".[test]"
- name: Run benchmarks
uses: CodSpeedHQ/action@v4
with:
mode: instrumentation
run: pytest benchmarks/ --codspeed
token: ${{ secrets.CODSPEED_TOKEN }} # Optional for public repos
🤖 Prompt for AI Agents
.github/workflows/codspeed.yml around lines 23 to 35: the workflow references an
unpublished actions/setup-python@v6 causing "Failed to resolve action"; update
the action reference to a published release (for example
actions/setup-python@v5) so the runner can resolve it and the job runs; keep the
rest of the step unchanged.

4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ docs/**/*.ipynb

# profile stuff from asv
.asv
.codspeed

# misc
scratch/**
Expand All @@ -95,3 +96,6 @@ docs/index.quarto_ipynb
# Claude stuff
.claude
CLAUDE.md

# profile stuff
prof/
184 changes: 0 additions & 184 deletions asv.conf.json

This file was deleted.

5 changes: 0 additions & 5 deletions benchmarks/__init__.py

This file was deleted.

49 changes: 0 additions & 49 deletions benchmarks/generic_io_benchmarks.py

This file was deleted.

84 changes: 0 additions & 84 deletions benchmarks/memory_spool_benchmarks.py

This file was deleted.

Loading
Loading