Plugin registry - #641
Conversation
Explains how to open a PR to add a row to the plugin registry CSVs so users get a helpful error message when the namespace is not installed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- DASCorePluginError now inherits from AttributeError (not ValueError) so hasattr() and getattr(..., default) work correctly when a namespace is registered but not installed - Add strict=True to zip() calls in _load_plugin_registry - Add test verifying hasattr returns False for uninstalled plugin namespaces Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add derzug (https://github.com/dasdae/derzug) to patch.csv and spool.csv - Docs table now deduplicates across CSVs and shows namespace + linked package_name in a single table instead of per-type tables - Refactor: cache-clear fixture is now class-scoped autouse in TestPluginRegistry - Remove test_multiple_rows_all_returned and strict=True from zip Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
qmd now just calls get_plugin_table_str(); one test added to test_doc_utils.py Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c175c86531
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pd.concat(frames, ignore_index=True) | ||
| .drop_duplicates(subset="namespace") | ||
| .sort_values("namespace")[["namespace", "package_name", "package_url"]] |
There was a problem hiding this comment.
get_plugin_table() currently concatenates every registry CSV and then deduplicates only on namespace, which loses information whenever the same namespace exists in more than one entry-point group. With this change that already collapses the two new zug registrations (patch.csv and spool.csv) into a single row, so supported_plugins.qmd can no longer tell readers whether a plugin is available on Patch, Spool, or both.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is by design; we only want them to know of the unique plugin packages from this page, not all the functionality they might have.
1 participant
Description
Adds a more structured registry for DASCore plug ins.
Replaces #640.
Changelog
Checklist
I have (if applicable):