Use fsspec for remote cache downloads - #758
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughChangesRemote download transport
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #758 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 161 161
Lines 16619 16587 -32
=========================================
- Hits 16619 16587 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d-chambers
marked this pull request as ready for review
July 19, 2026 17:56
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use fsspec/universal-pathlib as the single transport for remote cache materialization.
The HTTP cache fallback previously opened a second
urllibconnection because materialization could begin while the failed fsspec handle was still open. This duplicated HTTP behavior and required manually translating only a subset of fsspec storage options.This change closes the failed remote handle before materialization, then streams HTTP resources through
UPath.open(..., block_size=0). It removes the urllib-specific header/auth translation and the blocking-download timeout setting that only applied to that alternate stack. The existing atomic cache write and configured download chunk size remain unchanged.Regression tests verify that HTTP materialization uses the UPath/fsspec transport and that the failed remote handle is closed before the local cache opener runs.
Validation:
pytest tests -m "not network" -q— 7,735 passedpytest tests -m network -q— 100 passedpytest dascore --doctest-modules -q— 142 passedpre-commit run --all-files— passedChangelog
none
Checklist
I have (if applicable):
Summary by CodeRabbit