Skip to content

CI: test free-threaded Python build - #761

Closed
d-chambers wants to merge 3 commits into
devfrom
free-thread
Closed

CI: test free-threaded Python build#761
d-chambers wants to merge 3 commits into
devfrom
free-thread

Conversation

@d-chambers

@d-chambers d-chambers commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

Add a gating Ubuntu CPython 3.14 free-threaded build to the main test matrix under the display name free_thread.

  • Select the official 3.14t interpreter with actions/setup-python.
  • Install DASCore's core, test, and documentation dependencies from free-threaded wheels.
  • Assert after importing DASCore that the interpreter was built with Py_GIL_DISABLED=1 and the GIL remains disabled.
  • Reuse the existing test-data cache and the normal qmd, test-suite, doctest, and coverage steps.
  • Disable matrix fail-fast so a failure in this newer runtime does not cancel conventional Python coverage.

The free-threaded row intentionally does not install dascore[extras]: the current pymseed -> orjson dependency chain rejects free-threaded Python. Optional integration tests therefore skip normally while the supported DASCore core runs as a required job.

Testing

  • Python 3.14.6 free-threading runtime assertion: passed.
  • Full non-network suite with generated qmd tests: 7,724 passed, 232 skipped, 100 deselected, 2 xfailed.
  • Module doctests: 142 passed.
  • pre-commit run --all twice: passed, including actionlint.
  • Claude CLI ultrareview: one finding addressed by disabling matrix fail-fast.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings and/or appropriate doc page.
  • included tests. See testing guidelines.
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Summary by CodeRabbit

  • Tests
    • Expanded the automated test matrix to include free-threaded Python 3.14.
    • Added runtime checks to verify the free-threaded runs are executing with the GIL disabled.
    • Adjusted dependency installation and introduced free-threaded-specific test-data caching to improve reliability and speed.
    • Ensured documentation-related tests, unit tests, and doctests run under the appropriate shell/environment for each configuration.

@d-chambers d-chambers added ready_for_review PR is ready for review CI continuous integration labels Jul 21, 2026 — with ChatGPT Codex Connector
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@d-chambers, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 68a0724a-72bf-4375-8ae2-e8f2aa186829

📥 Commits

Reviewing files that changed from the base of the PR and between 0db4a14 and 306e13a.

📒 Files selected for processing (1)
  • .github/workflows/runtests.yml
📝 Walkthrough

Walkthrough

Changes

Free-threaded CI execution

Layer / File(s) Summary
Matrix and runtime setup
.github/workflows/runtests.yml
The test matrix adds Python 3.14t, disables fail-fast, bypasses mamba installation for that entry, installs dedicated dependencies, and verifies GIL-disabled execution.
Free-threaded test-data cache
.github/workflows/runtests.yml
The workflow exports cache settings, restores cached test data, primes it on misses, and saves regenerated data.
Matrix test execution
.github/workflows/runtests.yml
Documentation and code test steps use the matrix-selected shell, including PYTHON_GIL=0 for free-threaded runs.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: adding free-threaded Python CI testing.
Description check ✅ Passed The description follows the template with a clear summary, testing notes, and a mostly complete checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch free-thread

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef443abba7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/runtests.yml
Comment thread .github/workflows/runtests.yml
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (93d2707) to head (306e13a).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #761   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         163      163           
  Lines       17087    17087           
=======================================
  Hits        17081    17081           
  Misses          6        6           
Flag Coverage Δ
network 48.76% <ø> (ø)
unittests 99.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/runtests.yml:
- Around line 139-140: Update the workflow steps running
generate_doc_code_tests.py so shell does not interpolate matrix.test_shell
directly. Move the conditional shell selection into an environment variable and
reference it from shell, or split the steps with if: matrix.free_thread when
different shells are required, ensuring actionlint accepts the configuration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 32e2cfce-a83d-4de2-86d5-dd71cf71dbe0

📥 Commits

Reviewing files that changed from the base of the PR and between ef443ab and 0db4a14.

📒 Files selected for processing (1)
  • .github/workflows/runtests.yml

Comment thread .github/workflows/runtests.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant