Fix rank-0 coord select guard and fbe doc typo - #771
Conversation
|
Warning Review limit reached
Next review available in: 14 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
20bedbd to
6bd9cc4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #771 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 145 145
Lines 12859 12859
=======================================
Hits 12851 12851
Misses 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
44dd3a6 to
f5344f0
Compare
- coords: _select_by_sample_array used `ndim > 1`, so a rank-0 coord slipped past and crashed on `len()`. Use `ndim != 1`, matching the sibling guards in align_to/get_sample_count/change_length. Add a regression test. - fbe: fix "orginal" typo and the unbalanced paren in the dB docstring formula.
f5344f0 to
5de0332
Compare
Description
Two small fixes surfaced by a CodeRabbit review while integrating
masterintodev(#769). Split out here so the integration merge stays a pure merge.dascore/core/coords.py—_select_by_sample_arrayguarded onndim > 1, so a rank-0 coord (e.g.CoordPartial(shape=())) slipped past and then crashed onnp.arange(len(self))with an opaqueTypeError. Changed tondim != 1, matching the sibling guards already used inalign_to,get_sample_count, andchange_length. Added a regression test.dascore/transform/fbe.py— fixed the "orginal" typo and the unbalanced parenthesis in the dB docstring formula (20 * log10( sqrt(mean(x^2)) )).A third finding (map_fiber
_set_scalescale validation) was intentionally left alone — it's a private helper in an obscure plotting path where bad input already errors, and hardening it wasn't worth the added code.Checklist
I have (if applicable):
Verification
pytest tests/test_core/test_coords.py::TestDimensionalityErrors tests/test_transform/test_fbe.py— passed.pre-commit run --files <changed>— passed.