Stop persisting GITHUB_TOKEN in CI checkouts - #788
Conversation
actions/checkout leaves the job token in .git/config by default, so it stays readable by every later step, including the third-party tooling these jobs run (mamba, npm, quarto, pyodide-build). No DASCore workflow pushes with git: docs deploy through Netlify and actions/deploy-pages, releases through softprops/action-gh-release, and PyPI through gh-action-pypi-publish, all of which carry their own credentials. The only remote git call is 'git fetch --tags' in the mamba-install-dascore action, which works anonymously against this public repo and already runs credential-free in the network test job. Every checkout now sets persist-credentials: false, clearing the remaining zizmor 'artipacked' findings.
|
Warning Review limit reached
Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (99.98%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #788 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 164 164
Lines 17659 17659
=======================================
Hits 17657 17657
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Coverage gap is unrelated (since this didnt touch any actual code) |
Description
actions/checkoutdefaults topersist-credentials: true, which writes the job'sGITHUB_TOKENinto.git/configas anhttp.extraheader. It then stays readable by every subsequent step in the job, including the third-party tooling our workflows run (mamba/conda, npm, quarto, pyodide-build, codspeed).runtests.ymlalready setpersist-credentials: falseon the network job; this applies the same setting to the remaining 11 checkout steps.Nothing in CI needs the persisted credentials — no workflow pushes with git:
quarto publish(Netlify token) andactions/deploy-pages(OIDC)softprops/action-gh-releasepypa/gh-action-pypi-publishbuild_deploy_stable_docs.yamlonly runs localgit tag --list/git restoreThe one remote git call is
git fetch --tags --forcein.github/actions/mamba-install-dascore, which works anonymously against this public repo and already runs credential-free today in the network test job.This clears all
artipackedfindings from zizmor (uvx zizmor@1.26.1 .github/workflows/goes from 12 to 0; the remainingunpinned-usesfindings are pre-existing and out of scope).Raised by CodeRabbit on #783, which flagged the new WASM job's checkout. Rather than fix that one step in isolation, all of them are handled here. #783 keeps only the Pyodide version alignment.
Changelog
none
Checklist
I have (if applicable):