Don't let a pre-release tag become the stable docs version - #824
Don't let a pre-release tag become the stable docs version#824d-chambers wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 18 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing in favor of a single PR against |
Description
Found while reviewing whether a beta can safely be published from
dev. This is a latent bug that publishing the beta would activate, so it should land before any pre-release tag exists.BuildDeployStableDocsresolves "the latest release tag" for its manualworkflow_dispatchpath with:Git's version sort places a pre-release above its own final release. Reproduced in a scratch repo:
And in the situation we would actually be in right after tagging a beta:
So once
v0.2.0b1exists, any manual re-run of BuildDeployStableDocs would build docs from beta code and publish them as the stable site — and keep doing so even afterv0.2.0ships. The prerelease guard added in #811 does not prevent this, becausegithub.event.releaseis null forworkflow_dispatch. Fixed by matching only finalvX.Y.Ztags.The same bug exists on
master, which matters because the dispatch UI defaults tomaster; that needs a companion PR.Docs
Also documents how to publish a pre-release. The current guide is written for a stable release from
masterand would mislead on every step that matters:v0.2.0, which burns the final version numberdev(it defaults tomaster)--preand orders0.2.0b1above0.1.20, so a beta there would reach every conda userAlso adds a warning against re-running
PublishPackageafter the branch moves, since the version comes from the tag and a re-run then produces a local version segment that PyPI rejects.Verified:
Check Yamland actionlint pass; the edited shell block parses withbash -n; and both tag-selection scenarios above were reproduced before and after the change.Checklist
I have (if applicable):