Skip to content

Fix ty diagnostics from the crossed #833/#845 merges - #851

Merged
d-chambers merged 1 commit into
devfrom
fix-dev-ty
Aug 10, 2026
Merged

Fix ty diagnostics from the crossed #833/#845 merges#851
d-chambers merged 1 commit into
devfrom
fix-dev-ty

Conversation

@d-chambers

@d-chambers d-chambers commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Description

dev's lint job is currently broken: #833 (chunk-by-size) and #845 (ty-api-audit) each passed CI against pre-merge dev, but their combination fails pre-commit run ty with two diagnostics in dascore/utils/chunk_plan.py. Every open PR now fails lint on its merge ref until this lands, so this is a small unblock:

  • get_byte_count(value) in the size-diagnostics block: value can be None in merge mode, but diagnostics are only collected on the size-chunk path where it is an information Quantity — narrowed with an assert.
  • _output_dtypes: a scalar-returning apply on a SeriesGroupBy is always a Series, but the stubs claim DataFrame | Series — pinned with an annotated assignment and a ty: ignore[invalid-assignment] at the origin.

No behavioral changes.

Changelog

none

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings and/or appropriate doc page.
  • included tests (covered by the existing chunk/spool suites; tests/test_core/test_patch_chunk.py and test_spool.py pass locally).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Both PRs passed CI against pre-merge dev, but their combination fails
the ty hook: the size-diagnostics block calls get_byte_count on a value
ty cannot see is a Quantity there, and _output_dtypes returns through a
SeriesGroupBy.apply the stubs type as DataFrame | Series. Narrow the
first with an assert on the size-gated path and pin the second to
pd.Series where the union arises.
@d-chambers d-chambers added the ready_for_review PR is ready for review label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@d-chambers, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 356eaed4-d393-4b23-bbd6-77222ef2e99c

📥 Commits

Reviewing files that changed from the base of the PR and between 28fa0b8 and c92fa34.

📒 Files selected for processing (1)
  • dascore/utils/chunk_plan.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@d-chambers
d-chambers merged commit a005012 into dev Aug 10, 2026
15 checks passed
@d-chambers
d-chambers deleted the fix-dev-ty branch August 10, 2026 09:46
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.98%. Comparing base (28fa0b8) to head (c92fa34).
⚠️ Report is 2 commits behind head on dev.

❌ Your project status has failed because the head coverage (99.98%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #851   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         164      164           
  Lines       18191    18192    +1     
=======================================
+ Hits        18189    18190    +1     
  Misses          2        2           
Flag Coverage Δ
network 48.30% <0.00%> (-0.01%) ⬇️
unittests 99.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant