Fix ty diagnostics from the crossed #833/#845 merges - #851
Conversation
Both PRs passed CI against pre-merge dev, but their combination fails the ty hook: the size-diagnostics block calls get_byte_count on a value ty cannot see is a Quantity there, and _output_dtypes returns through a SeriesGroupBy.apply the stubs type as DataFrame | Series. Narrow the first with an assert on the size-gated path and pin the second to pd.Series where the union arises.
|
Warning Review limit reached
Next review available in: 45 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (99.98%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #851 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 164 164
Lines 18191 18192 +1
=======================================
+ Hits 18189 18190 +1
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
dev's lint job is currently broken: #833 (chunk-by-size) and #845 (ty-api-audit) each passed CI against pre-merge dev, but their combination fails
pre-commit run tywith two diagnostics indascore/utils/chunk_plan.py. Every open PR now fails lint on its merge ref until this lands, so this is a small unblock:get_byte_count(value)in the size-diagnostics block:valuecan beNonein merge mode, but diagnostics are only collected on the size-chunk path where it is an informationQuantity— narrowed with an assert._output_dtypes: a scalar-returningapplyon aSeriesGroupByis always aSeries, but the stubs claimDataFrame | Series— pinned with an annotated assignment and aty: ignore[invalid-assignment]at the origin.No behavioral changes.
Changelog
none
Checklist
I have (if applicable):
tests/test_core/test_patch_chunk.pyandtest_spool.pypass locally).