chore: refresh dependencies and CI coverage#40
Merged
Conversation
Assisted-by: Codex:gpt-5.5
Assisted-by: Codex:gpt-5.5
There was a problem hiding this comment.
Pull request overview
This PR refreshes the crate’s Tantivy integration to the current tantivy 0.26 line, updating the dependency stack and aligning tests/docs with the updated Tantivy APIs.
Changes:
- Bumped crate version and updated core dependencies (notably
tantivy 0.22 -> 0.26, plusjieba-rs,log,flexi_logger). - Updated tests for Tantivy 0.26 collector and snippet API changes (explicit
TopDocsordering; newSnippetGeneratorimport path). - Made the README usage snippet runnable as a Rust doctest by including
README.mdas crate docs and wrapping the example infn main() -> tantivy::Result<()>.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Updates crate version and bumps Tantivy/Jieba/logging dependencies to newer releases. |
tests/unicode_split.rs |
Adjusts TopDocs usage to comply with Tantivy 0.26’s explicit ordering requirement. |
tests/position.rs |
Updates TopDocs ordering and SnippetGenerator import path for Tantivy 0.26. |
src/lib.rs |
Includes README.md as crate-level docs so the README example is exercised via doctests. |
README.md |
Wraps the usage snippet in a main returning tantivy::Result so it can run as a doctest. |
.github/workflows/ci.yml |
Skips cargo-test in the lint job’s prek run (tests still run in the separate matrix job). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Assisted-by: Codex:gpt-5.5
Assisted-by: Codex:gpt-5.5
Assisted-by: Codex:gpt-5.5
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What
tantivyto0.26.1,jieba-rsto0.9.0,logto0.4.29, andflexi_loggerto0.31.8.0.19.0and adapt tests for Tantivy 0.26 API changes.cargo llvm-cov; the coverage job now covers the stable test lane.cargo-testexecution in the CI lint job.Breaking Change
tantivy 0.26.Validation
prek run --all-filescargo test --docrustup run 1.88.0 cargo test --workspacecargo llvm-cov --workspace --lcov --output-path lcov.infocargo publish --dry-run --allow-dirtytest,lint,coverage, andpublish-dry-run