Add Simon to list of undergraduate students #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update his lab_member file - Add a link to it in the main lab members page
There was a problem hiding this comment.
Pull Request Overview
This pull request adds Simon Ngassam as an undergraduate lab member by updating his personal page with his details and adding his link to the main lab members page.
- Updated Simon’s lab member page to include his name, education, and bio.
- Activated the Simon Ngassam entry and commented out the Sebastien Chow entry in the main lab members page.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lab_members/undergraduate/simon_ngassam/index.html | Replaces placeholder text with Simon’s details and adjusts social link information. |
| lab_members/index.html | Activates Simon’s list entry and deactivates Sebastien’s entry by commenting it out. |
Comment on lines
+97
to
+108
| <!-- <a class="social__link" target="_blank" rel="noopener noreferrer" href="https://soundcloud.com/youraccount"> | ||
| <svg class="social__icon" height="22px" width="22px" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 2499.9979999999996 1386.6950000000002"> | ||
| <path d="M0 1137.737c0 31.024 11.247 54.481 33.737 70.382 22.491 15.898 46.533 21.52 72.126 16.868 24.041-4.653 40.91-13.185 50.607-25.593 9.693-12.408 14.542-32.962 14.542-61.657V800.372c0-24.044-8.336-44.403-25.012-61.075-16.672-16.676-37.03-25.012-61.074-25.012-23.267 0-43.237 8.336-59.912 25.012C8.339 755.969 0 776.327 0 800.372zm267.566 144.253c0 22.495 7.95 39.36 23.848 50.608 15.9 11.247 36.26 16.868 61.075 16.868 25.593 0 46.338-5.624 62.238-16.868 15.898-11.245 23.849-28.113 23.849-50.608V495.58c0-23.267-8.34-43.239-25.012-59.912-16.675-16.672-37.033-25.011-61.075-25.011-23.266 0-43.239 8.339-59.911 25.011-16.676 16.676-25.012 36.645-25.012 59.912zm266.403 37.227c0 22.492 8.143 39.36 24.43 50.607 16.286 11.245 37.226 16.869 62.822 16.869 24.816 0 45.174-5.624 61.072-16.869 15.9-11.247 23.851-28.115 23.851-50.607V601.442c0-24.041-8.339-44.595-25.012-61.657-16.675-17.061-36.644-25.59-59.911-25.59-24.044 0-44.595 8.529-61.657 25.59-17.061 17.062-25.593 37.616-25.593 61.657v717.775zm267.566 3.49c0 42.657 28.695 63.986 86.086 63.986 57.39 0 86.084-21.329 86.084-63.986V159.377c0-65.147-19.776-101.985-59.33-110.517-25.593-6.205-50.8 1.163-75.616 22.103-24.818 20.94-37.227 50.41-37.227 88.413v1163.331zm272.222 33.737V90.74c0-40.328 12.02-64.37 36.063-72.127C1161.78 6.205 1213.356 0 1264.543 0c118.657 0 229.176 27.92 331.547 83.76 102.373 55.84 185.165 132.038 248.37 228.594 63.21 96.56 99.854 203.001 109.936 319.337 47.308-20.165 97.717-30.247 151.23-30.247 108.578 0 201.452 38.39 278.618 115.17 77.168 76.782 115.754 169.072 115.754 276.875 0 108.578-38.586 201.256-115.754 278.036-77.166 76.78-169.651 115.17-277.455 115.17l-1012.097-1.163c-6.983-2.327-12.218-6.594-15.708-12.797s-5.227-11.638-5.227-16.291z"/> | ||
| </svg> | ||
| </a> | ||
| </a> --> | ||
| <!-- TODO: link your Bandcamp in the href attribute here, or comment out the entire <a> tag --> | ||
| <a class="social__link" target="_blank" rel="noopener noreferrer" href="https://youraccount.bandcamp.com/releases"> | ||
| <!-- <a class="social__link" target="_blank" rel="noopener noreferrer" href="https://youraccount.bandcamp.com/releases"> | ||
| <svg class="social__icon" viewBox="0 0 24 26" width="22px" height="22px" xmlns="http://www.w3.org/2000/svg"> | ||
| <title/> | ||
| <path d="M0 18.75l7.437-13.5H24l-7.438 13.5H0z"/> | ||
| </svg> | ||
| </a> | ||
| </a> --> |
There was a problem hiding this comment.
[nitpick] There are several social link blocks now commented out using inline HTML comments. To improve maintainability and clarity, consider removing these unused code blocks if they are not planned for future use.
Comment on lines
+172
to
174
| <!-- <li><a href="../lab_members/undergraduate/sebastien_chow/">Sebastien Chow</a><a | ||
| href="../lab_members/undergraduate/sebastien_chow/"><img class="member_photo_list" | ||
| src="../assets/lab_members/thumbnail/placeholder.png" /></a></li> --> |
There was a problem hiding this comment.
[nitpick] The Sebastien Chow entry is now commented out. If this removal is intentional and permanent, consider deleting the commented code to improve readability.
Suggested change
| <!-- <li><a href="../lab_members/undergraduate/sebastien_chow/">Sebastien Chow</a><a | |
| href="../lab_members/undergraduate/sebastien_chow/"><img class="member_photo_list" | |
| src="../assets/lab_members/thumbnail/placeholder.png" /></a></li> --> | |
dchiller
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #174