fix: normalize chat completions system messages#458
Draft
MoeMion wants to merge 1 commit into
Draft
Conversation
Author
|
API returned {
"error": {
"code": "400",
"message": "System message must be at the beginning.",
"type": "BadRequestError"
}
}when system prompt not at beginning. |
|
This pull request has had no activity for 7 days. It will be closed in 7 days if there is no further activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Chat-completions-compatible providers can reject or inconsistently interpret requests containing multiple system messages at different positions. File context, tool guidance, and final synthesis instructions could therefore produce an invalid or ambiguous message sequence.
Impact
OpenAI Chat Completions and OpenRouter Chat requests are affected. Non-system messages, including tool calls and tool results, keep their original order and payload.
Changes
Validation
go test ./internal/infra/llmgo vet ./internal/infra/llmgofmt -d backend/internal/infra/llm/openai_chat_completions.go backend/internal/infra/llm/request_params_test.gogit diff --check upstream/dev...HEADFull
make testwas attempted, but unrelated SQLite packages could not compile in the local Windows CGO environment becausesqlite3.his unavailable.