Conversation
Allow multi-file selection when the component schema permits it, and render all selected files in the client-side upload summary.
Normalise CDP status to support multiple uploaded files, key file removal by fileId, and update tests to match.
| } | ||
|
|
||
| // Allow multiple file selection when schema permits more than 1 file | ||
| const allowsMultiple = schema.max !== 1 && schema.length !== 1 |
jbarnsley10
reviewed
Mar 25, 2026
| const errors: FormSubmissionError[] = [ | ||
| { path: [name], href: `#${name}`, name, text } | ||
| ] | ||
| cacheService.setFlash(request, { errors }) |
Contributor
There was a problem hiding this comment.
Does this overwrite the previous error if more than one file in error? Does it need to track potentially multiple errors or not really needed?
Contributor
Author
There was a problem hiding this comment.
That's a fantastic spot. I've pushed an update to fix this.
jbarnsley10
approved these changes
Mar 25, 2026
Contributor
jbarnsley10
left a comment
jbarnsley10
left a comment
There was a problem hiding this comment.
Looks great. Just one question
Prevents loss of error messages when multiple files fail upload.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Allow users to select and upload multiple files on file upload pages, wiring through CDP’s multi-file responses, updating the summary list and delete links to use fileId, and keeping existing single-file behaviour unchanged.
Jira ticket: https://eaflood.atlassian.net/browse/DF-868?atlOrigin=eyJpIjoiMjZjZTRlNWE2NDJkNGUxY2FlNzkxNTYyOGQ0ZDc0NTQiLCJwIjoiaiJ9
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).