sang myPage.html calender 추가하기#2
Open
zmo112 wants to merge 1 commit into
Open
Conversation
DEVdongbaek
reviewed
Oct 6, 2024
| <script src="https://cdn.jsdelivr.net/npm/bootstrap@5.2.3/dist/js/bootstrap.bundle.min.js"></script> | ||
| <!-- Responsive navbar--> | ||
| <script src="https://code.jquery.com/jquery-3.4.1.js"></script> | ||
| <script src="https://code.jquery.com/jquery-3.6.0.min.js"></script> |
Owner
There was a problem hiding this comment.
현재 Commit 된 코드들 중 주석을 제거한 부분이 많이 보이는데, 주석을 제한 이유가 있을까요?
Author
There was a problem hiding this comment.
주석 안보고 이해해보려고 잠시 지워놓았다가 복구하는걸 까먹은거 같습니다! ’-‘
DEVdongbaek
reviewed
Oct 6, 2024
| <th>Sat</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody id="calendarBody"></tbody> |
Owner
There was a problem hiding this comment.
해당 tbody 내의 요소를 클릭하였을 때 해당 날짜에 해당 하는 3감사 3회개 Data는 어떻게 가져올 수 있을지 추가적으로 생각해보면 좋을 것 같아요!
DEVdongbaek
reviewed
Oct 6, 2024
| </body> | ||
|
|
||
| <!-- Bootstrap core JS--> | ||
| <script src="https://cdn.jsdelivr.net/npm/bootstrap@5.2.3/dist/js/bootstrap.bundle.min.js"></script> |
Owner
There was a problem hiding this comment.
추가적으로 현재 저희는 CDN을 통해서 라이브러리들을 의존하고 있어요. 이 때 발생할 수 있는 문제점은 무엇이고, 이를 해결하기 위해서는 어떻게 해야 할지 생각해보면 좋을 것 같아요!
DEVdongbaek
reviewed
Oct 6, 2024
| }); | ||
|
|
||
| // Heart toggle on date click | ||
| $("#calendarBody").on("click", "td", function () { |
Owner
There was a problem hiding this comment.
현재 올려준 Commit 내용은 모두 온전히 Client Side에 대한 내용입니다. Server Side에 대한 경험도 해볼 겸 해당 유저가 Daily를 작성한 날짜에만 Heart를 activate 속성을 주는 기능을 구현해보는건 어떨까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
마이페이지에 캘린더와 누르면 하트를 추가하는 기능을 구현하였습니다!
