Skip to content

01a077f5 - Coordinate assigned issues through static scripts - #74

Merged
TaprootFreak merged 8 commits into
DFXswiss:developfrom
JonnyLuca:codex/01a077f5-issue-coordinator
Sep 8, 2026
Merged

01a077f5 - Coordinate assigned issues through static scripts#74
TaprootFreak merged 8 commits into
DFXswiss:developfrom
JonnyLuca:codex/01a077f5-issue-coordinator

Conversation

@JonnyLuca

@JonnyLuca JonnyLuca commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

EN:
Adds an optional static coordinator that accepts assigned GitHub issues and drives implementation, checks, reviews and pull-request readiness through explicitly configured accounts and roles. The script owns GitHub communication, process launches and monitoring; models return bounded work results. Installation remains unconfigured by default, and completion requires a verified human merge.

DE:
Ergänzt einen optionalen statischen Koordinator, der zugewiesene GitHub-Issues übernimmt und Umsetzung, Prüfungen, Reviews und PR-Bereitschaft über ausdrücklich konfigurierte Accounts und Rollen steuert. Das Script übernimmt GitHub-Kommunikation, Prozessstarts und Überwachung; die KI liefert begrenzte Arbeitsergebnisse zurück. Die Installation bleibt standardmäßig unkonfiguriert und der Abschluss erfordert einen nachgewiesenen menschlichen Merge.

Implementation and limits
  • Uses the existing task spine, activity executor, lane adapters and review gates; adds no second store or task-state schema.
  • Adds explicit worker/repository commands, account bindings and CLI/daemon integration without default workers, identities or models.
  • Pins checkout ownership, execution selections and review evidence; fails closed on uncertain processes, foreign worktrees, changed heads or incomplete approval data.
  • Static checks and configured readiness commands supply repository-specific evidence. CI checks include both the rollup and workflow-run inventory.
  • Operator configuration and trusted readiness commands remain required. Universal model sandbox enforcement and deployment are separate work; this PR does not claim a live pilot.
  • The user explicitly authorized the fork route; no test, review or CI waiver is claimed.
Validated Ready evidence

Validated head: 6bac9cedfb892996e44906cea785e4c7898adbd5.
Static-script full tests: 1617 passed, 3 skipped, 47 subtests passed in 120.16s (0:02:00).
Independent complete Grok inner review approved, followed by four independent PR review approvals: Grok quality and logic, then Codex quality and logic.
GitHub workflow inventory and check rollup are green on this head. The script verified the clean worktree, signature and formal approval by marassteiner.
Ready for review is not merged or completed; a human merges.

@JonnyLuca JonnyLuca left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grok logic — rejected at 40d80d6

src/agent_cli/coordinator_github.py:1391: A stale question checkpoint plus a later authorized reply can default back to implement after closed-unmerged or nonhuman-merge outcomes; require an eligible explicit resume phase and clear or ignore stale checkpoints for non-recoverable states.

@JonnyLuca JonnyLuca left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grok quality — rejected at 40d80d6

src/agent_cli/coordinator_github.py:436: Hard CI inventory shape or truncation faults keep phase=ci instead of entering the recoverable blocked/checkpoint path; distinguish protocol faults from transient transport and pending states.
src/agent_cli/coordinator_github.py:914: An unverified formal approval publication invalidates the durable attempt even on transient transport failure; preserve and reconcile that attempt unless actual revocation is observed.

@JonnyLuca JonnyLuca left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grok logic — rejected at ac5509a

src/agent_cli/coordinator_github.py:628: Fresh CI pending or transport failures during readiness, formal approval and leave-draft become a human reply gate through advance_one; preserve script-owned observation and retry without premature readiness.
src/agent_cli/coordinator_github.py:432: The phase_ci PR-view transport runs outside the transient inventory handling and still requires a human reply on a temporary fetch failure; apply the same hard-versus-transient classification to both CI sources.

@marassteiner marassteiner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formal approval for 6bac9cedfb892996e44906cea785e4c7898adbd5, submitted by the static executor through the explicitly selected separate review account.

Evidence verified before submission:

  • Four independent complete approvals on this exact head: Grok quality and logic, followed by Codex quality and logic; zero introduced findings.
  • Full static-script tests passed on the clean signed head.
  • Current-head GitHub workflow inventory and PR check rollup are green; PR is mergeable.

This publishes the recorded independent review results. It is not an additional model review and does not merge the PR. A human merges.

@JonnyLuca

Copy link
Copy Markdown
Contributor Author

Ready for review evidence for 6bac9cedfb892996e44906cea785e4c7898adbd5:

  • Review-pass count: 4 independent, complete approvals on this head: Grok quality + logic, then Codex quality + logic. Zero introduced findings.
  • Static-script tests: 1617 passed, 3 skipped, 47 subtests passed in 120.16s (0:02:00) on the clean signed head.
  • GitHub Actions test: success; current-head workflow inventory and PR check rollup both verified green.
  • Formal GitHub approval by marassteiner verified on this head: 01a077f5 - Coordinate assigned issues through static scripts #74 (review).
  • Commit signature verified; PR is mergeable. The fork is explicitly authorized for this change.

This is Ready for review, not merged or completed; merge remains with a human.

@JonnyLuca
JonnyLuca marked this pull request as ready for review September 7, 2026 23:05
@TaprootFreak
TaprootFreak merged commit 5035c80 into DFXswiss:develop Sep 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants