Skip to content

feat(compliance): require a note on AML decisions and record it in the KYC log #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Blume1977 wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

feat(compliance): require a note on AML decisions and record it in the KYC log #1277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions src/components/compliance/aml-check-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ interface AmlCheckPendingPanelProps {
data: ComplianceUserData;
clerks: string[];
isSaving: boolean;
onUpdate: (tx: TransactionInfo, update: AmlCheckUpdate, clerk: string) => Promise<void>;
onReset: (tx: TransactionInfo, clerk: string) => Promise<void>;
onUpdate: (tx: TransactionInfo, update: AmlCheckUpdate, clerk: string, note: string) => Promise<void>;
onReset: (tx: TransactionInfo, clerk: string, note: string) => Promise<void>;
}

const AML_CHECK_OPTIONS = [CheckStatus.PASS, CheckStatus.FAIL, CheckStatus.PENDING, 'Reset'] as const;
Expand All @@ -39,22 +39,23 @@ function TransactionEntry({
}: {
tx: TransactionInfo;
clerks: string[];
onUpdate: (data: AmlCheckUpdate, clerk: string) => Promise<void>;
onReset: (clerk: string) => Promise<void>;
onUpdate: (data: AmlCheckUpdate, clerk: string, note: string) => Promise<void>;
onReset: (clerk: string, note: string) => Promise<void>;
isSaving: boolean;
}): JSX.Element {
const [amlCheck, setAmlCheck] = useState(tx.amlCheck ?? '');
const [amlReason, setAmlReason] = useState<AmlReason>((tx.amlReason as AmlReason) ?? AmlReason.NA);
const [setPriceDate, setSetPriceDate] = useState(false);
const [clerk, setClerk] = useState('');
const [note, setNote] = useState('');
const [isProcessing, setIsProcessing] = useState(false);

async function handleSave(): Promise<void> {
if (!amlCheck || !clerk) return;
if (!amlCheck || !clerk || !note.trim()) return;
setIsProcessing(true);
try {
if (amlCheck === 'Reset') {
await onReset(clerk);
await onReset(clerk, note);
} else {
await onUpdate(
{
Expand All @@ -63,6 +64,7 @@ function TransactionEntry({
priceDefinitionAllowedDate: setPriceDate ? new Date().toISOString() : undefined,
},
clerk,
note,
);
}
} finally {
Expand Down Expand Up @@ -175,6 +177,21 @@ function TransactionEntry({
</div>
</div>

{/* Notiz: geht ins KycLog (wie bei den Telefon-Notizen), NICHT in den Transaktions-Comment —
dort stehen die AML-Fehler, auf die der Release-Mechanismus matcht. */}
<div className="bg-white rounded-lg shadow-sm px-3 py-3">
<label className="block text-sm text-dfxBlue-800 font-medium mb-1">Notiz *</label>
<textarea
className="w-full px-3 py-2 text-sm bg-white border border-dfxGray-300 rounded text-dfxBlue-800"
rows={3}
maxLength={500}
value={note}
onChange={(e) => setNote(e.target.value)}
placeholder="Infos zum Entscheid"
required
/>
</div>

{/* Clerk */}
<div className="bg-white rounded-lg shadow-sm px-3 py-3">
<div className="flex items-center justify-between">
Expand All @@ -198,7 +215,7 @@ function TransactionEntry({
<button
className="px-4 py-2 text-sm text-white bg-dfxBlue-800 hover:bg-dfxBlue-800/80 rounded-lg transition-colors disabled:opacity-50"
onClick={handleSave}
disabled={isSaving || isProcessing || !amlCheck || !clerk}
disabled={isSaving || isProcessing || !amlCheck || !clerk || !note.trim()}
>
{isProcessing ? 'Speichern...' : 'Speichern'}
</button>
Expand Down Expand Up @@ -349,8 +366,8 @@ export function AmlCheckPendingPanel({
<TransactionEntry
tx={tx}
clerks={clerks}
onUpdate={(updateData, clerk) => onUpdate(tx, updateData, clerk)}
onReset={(clerk) => onReset(tx, clerk)}
onUpdate={(updateData, clerk, note) => onUpdate(tx, updateData, clerk, note)}
onReset={(clerk, note) => onReset(tx, clerk, note)}
isSaving={isSaving}
/>
</div>
Expand Down
12 changes: 9 additions & 3 deletions src/screens/compliance-review.screen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,12 @@ export default function ComplianceReviewScreen(): JSX.Element {
}
}

async function handleAmlUpdate(tx: TransactionInfo, update: AmlCheckUpdate, clerk: string): Promise<void> {
async function handleAmlUpdate(
tx: TransactionInfo,
update: AmlCheckUpdate,
clerk: string,
note: string,
): Promise<void> {
setIsSaving(true);
setError(undefined);
try {
Expand All @@ -275,7 +280,7 @@ export default function ComplianceReviewScreen(): JSX.Element {
if (update.amlReason) results.push({ table, column: 'amlReason', value: update.amlReason });
if (update.priceDefinitionAllowedDate)
results.push({ table, column: 'priceDefinitionAllowedDate', value: update.priceDefinitionAllowedDate });
await createKycLog(+userDataId, buildKycLogMessage({ description: 'AmlCheck', clerk, results }));
await createKycLog(+userDataId, buildKycLogMessage({ description: 'AmlCheck', clerk, results, comment: note }));
}
loadData();
} catch (e: unknown) {
Expand All @@ -285,7 +290,7 @@ export default function ComplianceReviewScreen(): JSX.Element {
}
}

async function handleAmlReset(tx: TransactionInfo, clerk: string): Promise<void> {
async function handleAmlReset(tx: TransactionInfo, clerk: string, note: string): Promise<void> {
setIsSaving(true);
setError(undefined);
try {
Expand All @@ -300,6 +305,7 @@ export default function ComplianceReviewScreen(): JSX.Element {
description: 'AmlCheck',
clerk,
results: [{ table, column: 'amlCheck', value: 'Reset' }],
comment: note,
}),
);
}
Expand Down