fix(deps): patch browserslist security advisories - #262
Open
joshuakrueger-dfx wants to merge 1 commit into
Open
Conversation
joshuakrueger-dfx
marked this pull request as ready for review
September 2, 2026 12:37
joshuakrueger-dfx
requested review from
Danswar,
TaprootFreak and
davidleomay
as code owners
September 2, 2026 12:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the transitive Browserslist dependency to the minimal patched release
4.28.7using npm overrides. The lockfile updates only the dependency versions required by that release.Symptom (verbatim):
Unallowed high/critical vulnerabilities: browserslist [high]: GHSA-73WF-GQ98-2V4G, GHSA-C83G-RGW3-J3CXScale:
One package manifest entry and the corresponding lockfile resolution.
Smaller fix considered:
A direct dependency would unnecessarily expose a transitive build dependency. A broad
npm audit fixwas rejected because it can introduce unrelated upgrades; this override is the smallest scoped fix for the affected package.Evidence
origin/develop,npm audit --json --audit-level=highand the repository CI audit policy fail on the two Browserslist advisories.browserslist: 4.28.7inoverrides, the same CI policy passes with no non-allowlisted high/critical findings.<=4.28.6as affected and4.28.7as patched: GHSA-73wf-gq98-2v4g and GHSA-c83g-rgw3-j3cxValidation
npm ci --legacy-peer-deps --ignore-scriptsnpm run checknpm test -- --coveragenode scripts/check-coverage-floor.mjsnode scripts/check-feature-matrix.mjsnode scripts/check-visual-coverage.mjsand--self-testnpm run bundle:wdknpm run e2e:build:iosKnown unrelated repository/toolchain issue:
npm run bundle:bitboxstill targets the nonexistentsrc/services/hardware-wallet/bitbox-wasm-html.tspath ondevelop; no BitBox source or runner path was changed here.Measured lockfile churn: 23 additions and 20 deletions, all limited to browserslist and its required browser-data dependency resolutions.