01a035df - Serve GET /v1/statistic/status from the cached list root - #15
Merged
Merged
Conversation
Contributor
Author
|
EN: DE: DetailsGates at head
|
TaprootFreak
marked this pull request as ready for review
August 24, 2026 23:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
Listed nested GET /v1/statistic/status was answered with 503 not served even when the list-root cache held a status object. This change stores that object under the nested cache key whenever GET /v1/statistic is cached with HTTP 200. A miss stays 503 and is never forwarded. Keyword monitors that look for ONLINE on this path can succeed again after deploy.
DE:
Der gelistete nested GET /v1/statistic/status antwortete mit 503 not served, obwohl der List-Root-Cache bereits ein status-Objekt hatte. Diese Änderung legt dieses Objekt unter den nested Cache-Key, sobald GET /v1/statistic mit HTTP 200 gecacht wird. Ein Miss bleibt 503 und wird nie weitergeleitet. Keyword-Monitore, die auf diesem Pfad nach ONLINE suchen, können nach dem Deploy wieder grün werden.
Details
The list root
GET /v1/statisticis aCACHE_PREFIXESentry and is filled in the background. Nested/v1/statistic/statusis alreadyisServedPath(prefix match) so a miss is local 503, never a backend fetch. The list-root JSON embedsstatus: { buy, sell, … }, which is the body of the nested path.putCache('GET /v1/statistic', 200, …)now copies a non-array objectstatusfield toGET /v1/statistic/status. Invalid JSON, a missing/null/array/non-objectstatus, or a non-200 parent does not fan out. Replacing the parent with a body that has no status object deletes the nested key so a stale status is not served.Pins in
test/server.test.jscover fan-out, drop-on-replace, HTTP 200x-front-api: hitafter refresh, and 503-not-forwarded on miss.test/test-server.shgreps the production helper. Catalog: the/v1/statisticusedIn note was updated; no new catalog row.REVIEW item 11: the
/v1/statistice2e pointer staysunidentified. There is no public frontend flow that hits/v1/statistic/status. The behaviour is pinned in this repository. Written grant requested to land without a new consumer e2e.