654 ajouter plusieurs erreursreco par critère#1458
Open
emma11y wants to merge 61 commits into
Hidden character warning
The head ref may contain hidden characters: "654-ajouter-plusieurs-erreursreco-par-crit\u00e8re"
Open
Conversation
emma11y
force-pushed
the
654-ajouter-plusieurs-erreursreco-par-critère
branch
from
8c47440 to
04b1d89
Compare
emma11y
force-pushed
the
654-ajouter-plusieurs-erreursreco-par-critère
branch
from
8101ea6 to
b3db248
Compare
…ak in report errors
…acter and move some css
hissalht
reviewed
Jun 25, 2026
Comment on lines
+25
to
+26
| const item = { ...props.item }; | ||
| item[field] = value as never; |
Collaborator
There was a problem hiding this comment.
as never ?
Pourquoi pas juste faire
const item = { ...props.item, [field]: value };D’ailleurs, on peut typer value pour éviter any
function handleItemChange(
field: keyof NotCompliantItem,
value: NotCompliantItem[keyof NotCompliantItem]
) {
}
bellangerq
force-pushed
the
654-ajouter-plusieurs-erreursreco-par-critère
branch
from
6be9266 to
4ad3bb7
Compare
hissalht
reviewed
Jun 26, 2026
| userImpact: CriterionResultUserImpact | null; | ||
| quickWin: boolean; | ||
| }; | ||
|
|
Collaborator
There was a problem hiding this comment.
Ce type ne corresponds pas à ce que renvoie l’API.
On peut utiliser components["schemas"]["NotCompliantItem"] qui est généré par le back et corresponds à ce que renvoie l’API.
Je vois que l’id est défini comme possiblement undefined, je suppose pour pouvoir représenter un nouvel NotCompliantItem qu’on envoie à l’API pour en créer un. Dans ce cas, il vaut mieux utiliser le type généré correspondant.
…usieurs-erreursreco-par-critère
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #654
Avant de merger la pull request, s’assurer que :