Only Render Plan's "Add a Contributor" Button For Users With Sufficient Permissions#3442
Open
aaronskiba wants to merge 2 commits intodevelopmentfrom
Open
Only Render Plan's "Add a Contributor" Button For Users With Sufficient Permissions#3442aaronskiba wants to merge 2 commits intodevelopmentfrom
aaronskiba wants to merge 2 commits intodevelopmentfrom
Conversation
aaronskiba
changed the title
Prior to this commit, even plan collaborators with "Read only" access could add/edit plan contributors.
aaronskiba
force-pushed
the
aaron/issues/3439
branch
from
a9a424f to
eccd6de
Compare
aaronskiba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3439
Changes proposed in this PR:
if @plan.editable_by?(current_user.id)permission check prevents users with "Read only" access from accessing the button.