Retain "Published" etc. Filter Setting When Applying Search or "View All" on /org_admin/templates/ Pages#3475
Open
aaronskiba wants to merge 3 commits intoDMPRoadmap:developmentfrom
Conversation
This commit retains the selected 'Published', 'Unpublished', or 'Not customized' filter when using the search on the paths /org_admin/templates, org_admin/templates/organisational, and org_admin/templates/customisable. Previously, the search would ignore the filter and return all templates.
This commit retains the selected 'Published', 'Unpublished', or 'Not customized' filter when using the "Select All" pagination option on the paths /org_admin/templates, org_admin/templates/organisational, and org_admin/templates/customisable. Previously, clicking "Select All" would ignore the filter and return all templates.
aaronskiba
changed the title
/org_admin/templates/ Page/org_admin/templates/ Pages
aaronskiba
changed the title
/org_admin/templates/ Pages/org_admin/templates/ Pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE NOTE:
Template.latest_versionAmbiguity Error #3474 has already been merged, aPG::AmbiguousColumn: ERROR:will be encountered when attempting to execute any searches on the pages/org_admin/templates,org_admin/templates/organisational, ororg_admin/templates/customisable. That PR's changes must be applied to properly test this PR.Changes proposed in this PR:
Retain
:ffilter on/org_admin/templates/Search c0a0dbf/org_admin/templates,org_admin/templates/organisational, andorg_admin/templates/customisable. Previously, the search would ignore the filter and return all templates.Retain
:ffilter on/org_admin/templates/"View All" d0fdcb7/org_admin/templates,org_admin/templates/organisational, andorg_admin/templates/customisable. Previously, clicking "Select All" would ignore the filter and return all templates.